Replaced https-socket-options test using fixtures #15882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir
pawelgolda
reviewed
Oct 6, 2017
| @@ -30,8 +31,8 @@ const fs = require('fs'); | |||
| const http = require('http'); | |||
|
|
|||
| const options = { | |||
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | |||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | |||
| key: fixtures.readSync(`/keys/agent1-key.pem`), | |||
There was a problem hiding this comment.
This could be readKey method instead of readSync
changing calls from fixtures.readSync to fixtures.readKey where applicable.
|
Thanks for catch that @pawelgolda |
fixed typo with pem key`
Trott
added
the
code-and-learn
cjihrig
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 10, 2017
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| 'use strict'; | |||
| const common = require('../common'); | |||
| const fixtures = require('../common/fixtures'); | |||
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check?
gireeshpunathil
approved these changes
Oct 12, 2017
|
CI is showing green, but no tests were actually run. Something is not working on CI. Will have to run again after it's fixed. |
joyeecheung
previously requested changes
Oct 14, 2017
There was a problem hiding this comment.
Linter complained:
not ok 2 - /usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-https-socket-options.js
---
message: '''fs'' is assigned a value but never used.'
severity: error
data:
line: 30
column: 7
ruleId: no-unused-vars
...
can you remove const fs = require('fs'); at line 30?
jasnell
pushed a commit
that referenced
this pull request
Oct 15, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: #15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in bb9ed92 |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: #15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: nodejs/node#15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: #15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: #15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
NINA 2017 Code and Learn session for first time contributors. This touched test/parallel/test-https-socket-options.js to replace common.fixturesDir PR-URL: #15882 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NINA 2017 Code and Learn session for first time contributors. This
touched test/parallel/test-https-socket-options.js to replace
common.fixturesDir
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)