test: replace common.fixturesDir with common.fixtures #15894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 9, 2017
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`) |
There was a problem hiding this comment.
There is the dedicated fixtures.readkey function that could and should be used instead. Would you be so kind and please update this?
gibfahn
approved these changes
Oct 9, 2017
cjihrig
approved these changes
Oct 11, 2017
|
Landed in 1c28dfa, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 12, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15894 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test