test: replaced fixturesDir with fixtures module #15908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test.
watilde
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
benjamingr
reviewed
Oct 7, 2017
| const assert = require('assert'); | ||
| const path = require('path'); | ||
|
|
||
| if (common.isWindows) { | ||
| const file = path.join(common.fixturesDir, 'a.js'); | ||
| const file = path.join(fixtures.fixturesDir, 'a.js'); |
There was a problem hiding this comment.
Hey, this can be a fixures.path('a.js')
BridgeAR
approved these changes
Oct 9, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: #15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 585c119 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: #15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: nodejs/node#15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: #15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: #15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
This was an assigned task at Node.js Interactive North America 2017. This replaced the fixturesDir exported by the common module with the fixturesDir on the common/fixtures module in the path-makelong test. PR-URL: #15908 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module in the path-makelong test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test