Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace common.fixturesDir with common.fixtures #15949

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with common.fixtures #15949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/parallel/test-stdin-from-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
'use strict';
const common = require('../common');
const { path } = require('../common/fixtures');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat confusing because it has the same name as the path module and therefore I would normally expect it to be the path module. It would be nicer to use the fixture name here instead.

const assert = require('assert');
const join = require('path').join;
const { join } = require('path');
const childProcess = require('child_process');
const fs = require('fs');

const stdoutScript = join(common.fixturesDir, 'echo-close-check.js');
const stdoutScript = path('echo-close-check.js');
const tmpFile = join(common.tmpDir, 'stdin.txt');

const cmd = `"${process.argv[0]}" "${stdoutScript}" < "${tmpFile}"`;
Expand Down