Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: template literals in tools/doc/html.js #15956

Closed
wants to merge 1 commit into from
Closed

tools: template literals in tools/doc/html.js #15956

wants to merge 1 commit into from

Conversation

sarahmeyer
Copy link
Contributor

@sarahmeyer sarahmeyer commented Oct 6, 2017 •
edited by BridgeAR
Loading

replaces string concatenation in tools/doc/html.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR BridgeAR removed the doc Issues and PRs related to the documentations. label Oct 7, 2017
@BridgeAR BridgeAR changed the title tools, doc: template literals in tools/doc/html.js tools: template literals in tools/doc/html.js Oct 7, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Oct 7, 2017

CI https://ci.nodejs.org/job/node-test-pull-request/10470/

@BridgeAR BridgeAR self-assigned this Oct 8, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 8, 2017
@sarahmeyer @BridgeAR
tools: use template literals
28a5fd0 
PR-URL: nodejs#15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 8, 2017

Landed in 28a5fd0

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@sarahmeyer @MylesBorins
tools: use template literals
94c6296 
PR-URL: #15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@sarahmeyer @addaleax
tools: use template literals
dc9e1cb 
PR-URL: nodejs/node#15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@sarahmeyer @MylesBorins
tools: use template literals
97cf4f1 
PR-URL: #15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@sarahmeyer @MylesBorins
tools: use template literals
2fefc17 
PR-URL: #15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@sarahmeyer @MylesBorins
tools: use template literals
705202d 
PR-URL: #15956
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sarahmeyer @BridgeAR @watilde @cjihrig @tniessen @MylesBorins @Trott @nodejs-github-bot