test: upgrade from common.fixturesDir to common.fixtures.path #15960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeinjam
changed the title
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory.
watilde
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
benjamingr
approved these changes
Oct 7, 2017
BridgeAR
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 8, 2017
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. PR-URL: nodejs#15960 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in ca4e549 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. PR-URL: #15960 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. PR-URL: nodejs/node#15960 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes