Modified pipePrefix to using relative path verses full path. #15988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed because my full path was 120+ characters
Trott
added
the
code-and-learn
jasnell
reviewed
Oct 9, 2017
| exports.PIPE = pipePrefix + pipeName; | ||
|
|
There was a problem hiding this comment.
Just a nit: this extra new line is unnecessary
lpinca
approved these changes
Oct 13, 2017
|
CI will need to be re-run. It didn't run any tests/sub-tasks. Hopefully @nodjes/build has this fixed or will have it fixed soon... |
|
CI failures look unrelated. Landed in 971aad1 with #15988 (comment) fixed. Thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
Modified pipePrefix to use relative path on windows, previously tests failed when the full path was 120+ characters PR-URL: #15988 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Modified pipePrefix to use relative path on windows, previously tests failed when the full path was 120+ characters PR-URL: nodejs/node#15988 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Modified pipePrefix to use relative path on windows, previously tests failed when the full path was 120+ characters PR-URL: #15988 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Should this be backported to |
|
If this is backported it should come with #16364. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified pipePrefix because if full path character count is to long you will get an error about port.
Test was done by using the following based on my directory ./node /Users/appleman/GitRepositories/github/NodeInteractiveWorkShops/FridayCodeAndLearn/node/test/parallel/test-tls-net-connect-prefer-path.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)