Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.fixtures module #15992

Closed
wants to merge 1 commit into from
Closed

test: use common.fixtures module #15992

wants to merge 1 commit into from

Conversation

shaun-sweet
Copy link
Contributor

@shaun-sweet shaun-sweet commented Oct 6, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@shaun-sweet shaun-sweet changed the title Use common.fixtures module common: use common.fixtures module Oct 6, 2017
@shaun-sweet shaun-sweet changed the title common: use common.fixtures module test: use common.fixtures module Oct 6, 2017
@mscdex mscdex added the cli Issues and PRs related to the Node.js command line interface. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10663/

@Trott
Copy link
Member

Trott commented Oct 13, 2017

CI is showing green, but no tests were actually run. Something is not working on CI. Will have to run again after it's fixed.

@Trott
Copy link
Member

Trott commented Oct 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10708/

@joyeecheung
Copy link
Member

Landed in b9ad14d, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
@shaun-sweet @joyeecheung
test: use common.fixtures module
b9ad14d 
PR-URL: #15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@shaun-sweet @addaleax
test: use common.fixtures module
f0cf222 
PR-URL: nodejs/node#15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@shaun-sweet @targos
test: use common.fixtures module
3a77a2d 
PR-URL: #15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@shaun-sweet @MylesBorins
test: use common.fixtures module
9dbe298 
PR-URL: #15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@shaun-sweet @MylesBorins
test: use common.fixtures module
fc4fa2e 
PR-URL: #15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@shaun-sweet @MylesBorins
test: use common.fixtures module
38179fd 
PR-URL: #15992
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@shaun-sweet @gireeshpunathil @Trott @joyeecheung @jasnell @lpinca @BridgeAR @mscdex @MylesBorins @nodejs-github-bot