Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internet: improve assert message #15998

Closed
wants to merge 5 commits into from
Closed

internet: improve assert message #15998

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b2b6cc
internet: improve assert message
Oct 6, 2017
7374adb
Remove all white spaces
Oct 12, 2017
301e7f1
Add one space
Oct 12, 2017
3523ff6
Swap arguments
Oct 16, 2017
68f8786
Removed message
Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/internet/test-dgram-broadcast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ if (process.argv[2] !== 'child') {
assert.strictEqual(
count,
messages.length,
'A worker received an invalid multicast message'
'A worker received an invalid multicast message. ' +
`Received ${messages.length} and wanted ${count}.`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be Received ${count} and wanted ${messages.length}.?
Personally I would just remove the "message" argument and use the default error message.

Copy link
Author

@nikkipelchat nikkipelchat Oct 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is the right way I think, I asked at the code and learn to make sure. If they don't want the message they can close this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikkistonge I think you might be misunderstanding what @lpinca means in their comment. I think what @lpinca is trying to say is that messages.length and count should be swapped with each other in the message string added on line 157. It's backwards in the PR as it stands now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok swapped them

);
});

Expand Down