Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added a test comment #16003

Closed
wants to merge 1 commit into from
Closed

test: added a test comment #16003

wants to merge 1 commit into from

Conversation

earobinson
Copy link
Contributor

@earobinson earobinson commented Oct 6, 2017 •
edited
Loading

Added comments to the tests to better describe what the test is doing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the debugger label Oct 6, 2017
BridgeAR
BridgeAR approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@Trott
Copy link
Member

Trott commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10520/

@earobinson earobinson force-pushed the earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils branch from 92ef77a to 895e8c6 Compare October 10, 2017 12:29
@joyeecheung
Copy link
Member

This doesn't seem to be about migrating string concatenations anymore after the update. It's more about adding a comment explaining what this test does now?

@earobinson
Copy link
Contributor Author

@joyeecheung I would agree, would you suggest I rebase and update the comment or just edit the pr description?

Trott
Trott reviewed Oct 11, 2017
View reviewed changes
test/sequential/test-debugger-debug-brk.js Outdated
const fixtures = require('../common/fixtures');

// This test ensures that the debug-brk flag will spin up a new process and
// wait, aka not quit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro-nit that you can ignore if you wish: aka not quit may be a bit unclear to people unfamiliar with a.k.a. Might be better as ...and wait, rather than exit.

@Trott
Copy link
Member

Trott commented Oct 11, 2017

@joyeecheung I would agree, would you suggest I rebase and update the comment or just edit the pr description?

@earobinson I'd say update both if it's not a hassle for you. (Whoever lands the commit can update the commit message, but you'd be saving them a bit of work if you do it yourself, plus that eliminates the possibility that they'll forget to do it.)

@earobinson
test: added a test comment
c912eaa 
Added comments to the tests to better describe what the test is doing.
@earobinson earobinson force-pushed the earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils branch from 895e8c6 to c912eaa Compare October 11, 2017 19:22
@earobinson earobinson changed the title test: Update to use common utilities conventions test: added a test comment Oct 11, 2017
@earobinson
Copy link
Contributor Author

@Trott rebased, and updated the pr.

@Trott
Copy link
Member

Trott commented Oct 12, 2017 •
edited
Loading

Landed in 7205e0a

@Trott Trott closed this Oct 12, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 12, 2017
@earobinson @Trott
test: added a test comment
7205e0a 
Added comments to the tests to better describe what the test is doing.

PR-URL: nodejs#16003
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@earobinson earobinson deleted the earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils branch October 12, 2017 14:26
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@earobinson @addaleax
test: added a test comment
25e1316 
Added comments to the tests to better describe what the test is doing.

PR-URL: nodejs/node#16003
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@earobinson @targos
test: added a test comment
56dd825 
Added comments to the tests to better describe what the test is doing.

PR-URL: #16003
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@earobinson @targos
test: added a test comment
859ce10 
Added comments to the tests to better describe what the test is doing.

PR-URL: #16003
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@earobinson @Trott @joyeecheung @jasnell @BridgeAR @mscdex @MylesBorins @nodejs-github-bot