Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all assert.strictEqual() to have actual 1st and expected 2nd #16008

Closed
wants to merge 1 commit into from
Closed

Change all assert.strictEqual() to have actual 1st and expected 2nd #16008

wants to merge 1 commit into from

Conversation

czezula
Copy link
Contributor

@czezula czezula commented Oct 6, 2017

Checklist
  • vcbuild test (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

none

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10660/

jasnell pushed a commit that referenced this pull request Oct 13, 2017
@czezula @jasnell
test: fix ordering of strictEqual actual/expected
ce9d55d 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: #16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

Landed in ce9d55d. Thank you!

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@czezula @addaleax
test: fix ordering of strictEqual actual/expected
0ea0c8c 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: nodejs/node#16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@czezula @targos
test: fix ordering of strictEqual actual/expected
8e2064f 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: #16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@czezula @MylesBorins
test: fix ordering of strictEqual actual/expected
f5a1806 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: #16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@czezula @MylesBorins
test: fix ordering of strictEqual actual/expected
517ff1c 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: #16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@czezula @MylesBorins
test: fix ordering of strictEqual actual/expected
18479d3 
Change all assert.strictEqual() to have actual value 1st
and expected value 2nd.

PR-URL: #16008
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@czezula @joyeecheung @jasnell @Trott @cjihrig @mscdex @MylesBorins @nodejs-github-bot