-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve crypto HMAC test assertions #16026
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argument order for assertions and makes their failure messages more descriptive and easier to debug.
sholladay
changed the title
improve crypto HMAC test assertions
test: improve crypto HMAC test assertions
Oct 6, 2017
BridgeAR
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
cjihrig
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Oct 7, 2017
addaleax
approved these changes
Oct 7, 2017
lance
approved these changes
Oct 9, 2017
CI: https://ci.nodejs.org/job/node-test-pull-request/10546/ Edit |
Landed in: fe38ace @sholladay thank you for your contribution! It's much appreciated. |
lance
pushed a commit
that referenced
this pull request
Oct 9, 2017
Fixes argument order for assertions and makes their failure messages more descriptive and easier to debug. PR-URL: #16026 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Fixes argument order for assertions and makes their failure messages more descriptive and easier to debug. PR-URL: nodejs/node#16026 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Fixes argument order for assertions and makes their failure messages more descriptive and easier to debug. PR-URL: #16026 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
crypto
Issues and PRs related to the crypto subsystem.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test