test: increase coverage for ModuleMap #16045

robtpaton · 2017-10-06T19:51:31Z

Checklist

tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

jasnell · 2017-10-09T23:08:35Z

bmeck · 2017-10-09T23:13:59Z

This looks to duplicate a bit of #16061 , but includes an actual test for ModuleJob which the other doesn't. We could merge the files I think. @jasnell do you think we should land as separate or merge the files?

jasnell · 2017-10-09T23:33:07Z

Could be a duplicate. merging the two should be fine.

Trott · 2017-10-11T06:11:51Z

@bmeck Could always land now as separate files and anyone who feels strongly about it can merge code in a subsequent PR.

FWIW, I don't mind a lot of similar code in tests if it makes each test more comprehensible as a standalone entity. (For anyone generally interested in why "DRY" may not be desirable in tests, see e.g. https://stackoverflow.com/a/11837973/436641)

bmeck · 2017-10-11T11:37:21Z

@Trott I like it.

Qard · 2017-10-11T18:39:18Z

Yep, I'd definitely lean toward clarity of tests over conciseness.

jasnell

Very close. One change that I can see.

jasnell · 2017-10-13T01:46:37Z

test/es-module/test-esm-loader-modulemap.js

+
+assert.throws(() => {
+  moduleMap.get(1);
+}, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "url" argument must be of type string/);


These should use...

common.expectsError( () => moduleMap.get(1), { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, message: 'The "url" argument must be of type string' } );

Hi @jasnell I've update the tests to use common.expectsError as suggested

Thanks!

cjihrig · 2017-10-15T13:35:53Z

test/es-module/test-esm-loader-modulemap.js

+
+const { URL } = require('url');
+
+const common = require('../common');


Please make this the first require() statement (just move it before require('url')).

BridgeAR · 2017-10-18T14:23:48Z

@jasnell I think you forgot to update your LG.

@robtpaton it would be nice if you could rebase to remove the merge commit.

robtpaton · 2017-10-19T12:26:42Z

@BridgeAR I've rebased to remove the merge commit

Thanks!
Rob

Trott · 2017-10-27T16:42:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11023/

joyeecheung · 2017-10-28T13:07:43Z

test/es-module/test-esm-loader-modulemap.js

+const stubModule = createDynamicModule(['default'], stubModuleUrl);
+const loader = new Loader();
+const moduleMap = new ModuleMap();
+const moduleJob = new ModuleJob(loader, stubModule.module);


CI failed across all platforms:

not ok 2040 es-module/test-esm-loader-modulemap --- duration_ms: 0.72 severity: fail stack: |- internal/loader/ModuleJob.js:18 this.modulePromise = this.moduleProvider(url); ^ TypeError: this.moduleProvider is not a function at new ModuleJob (internal/loader/ModuleJob.js:18:31) at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/es-module/test-esm-loader-modulemap.js:19:19) at Module._compile (module.js:616:30) at Object.Module._extensions..js (module.js:627:10) at Module.load (module.js:535:32) at tryModuleLoad (module.js:478:12) at Function.Module._load (module.js:470:3) at Function.Module.runMain (module.js:657:10) at startup (bootstrap_node.js:191:16) at bootstrap_node.js:613:3 ...

new ModuleJob needs a moduleProvider as the third argument.

I think you can just use a function that returns a never-resolving Promise for this

gireeshpunathil · 2017-10-31T06:33:12Z

ping @robtpaton - can you please address @joyeecheung / @addaleax 's comments?

Trott · 2017-11-01T13:53:21Z

Rebased, fixed the issue, force-pushed. Hope that's OK, @robtpaton!

PTAL, especially @joyeecheung.

CI: https://ci.nodejs.org/job/node-test-pull-request/11129/

Trott · 2017-11-01T15:48:15Z

Some build-specific (that is: unrelated to this PR) failures on that last CI. Here's another one:

CI: https://ci.nodejs.org/job/node-test-pull-request/11130/

Add test for ModuleMap set with ModuleJob but bad url. PR-URL: nodejs#16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Trott · 2017-11-01T20:33:30Z

Landed in d1a9c02.

Thanks for the contribution! 🎉

Add test for ModuleMap set with ModuleJob but bad url. PR-URL: nodejs/node#16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

robtpaton · 2017-11-02T12:49:17Z

Thanks for getting this over the line @Trott

Add test for ModuleMap set with ModuleJob but bad url. PR-URL: nodejs#16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Add test for ModuleMap set with ModuleJob but bad url. PR-URL: #16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Add test for ModuleMap set with ModuleJob but bad url. PR-URL: nodejs/node#16045 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017

mscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 6, 2017

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017

Qard approved these changes Oct 11, 2017

View reviewed changes

bmeck approved these changes Oct 11, 2017

View reviewed changes

jasnell requested changes Oct 13, 2017

View reviewed changes

cjihrig approved these changes Oct 15, 2017

View reviewed changes

jasnell approved these changes Oct 18, 2017

View reviewed changes

robtpaton force-pushed the increase-coverage branch from 79e3110 to 65a4ac2 Compare October 19, 2017 12:22

joyeecheung requested changes Oct 28, 2017

View reviewed changes

robtpaton and others added 8 commits November 1, 2017 06:15

test: increase coverage for ModuleMap

82e91df

Started adding tests

f121d97

add test for ModuleMap set with ModuleJob but bad url

8ec3e59

Finished tests

3f3608f

Fix typo

f5cd4c5

Use common for asserting errors are thrown

5ead8e0

[Squash] Address nits

0f9db3e

squash; add third argument

9888535

Trott force-pushed the increase-coverage branch from 65a4ac2 to 9888535 Compare November 1, 2017 13:52

joyeecheung approved these changes Nov 1, 2017

View reviewed changes

Trott closed this Nov 1, 2017

cjihrig mentioned this pull request Nov 6, 2017

v9.1.0 proposal #16851

Merged

MylesBorins added the dont-land-on-v6.x label Nov 14, 2017

gibfahn added the land-on-v8.x label Nov 14, 2017

gibfahn mentioned this pull request Nov 21, 2017

v8.9.2 proposal #17204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: increase coverage for ModuleMap #16045

test: increase coverage for ModuleMap #16045

robtpaton commented Oct 6, 2017 •

edited

Loading

jasnell commented Oct 9, 2017

bmeck commented Oct 9, 2017

jasnell commented Oct 9, 2017

Trott commented Oct 11, 2017

bmeck commented Oct 11, 2017

Qard commented Oct 11, 2017

jasnell left a comment

jasnell Oct 13, 2017

robtpaton Oct 13, 2017

cjihrig Oct 15, 2017

BridgeAR commented Oct 18, 2017

robtpaton commented Oct 19, 2017

Trott commented Oct 27, 2017

joyeecheung Oct 28, 2017

addaleax Oct 29, 2017

gireeshpunathil commented Oct 31, 2017

Trott commented Nov 1, 2017

Trott commented Nov 1, 2017 •

edited

Loading

Trott commented Nov 1, 2017

robtpaton commented Nov 2, 2017


		const { URL } = require('url');

		const common = require('../common');

test: increase coverage for ModuleMap #16045

test: increase coverage for ModuleMap #16045

Conversation

robtpaton commented Oct 6, 2017 • edited Loading

Checklist

Affected core subsystem(s)

jasnell commented Oct 9, 2017

bmeck commented Oct 9, 2017

jasnell commented Oct 9, 2017

Trott commented Oct 11, 2017

bmeck commented Oct 11, 2017

Qard commented Oct 11, 2017

jasnell left a comment

Choose a reason for hiding this comment

jasnell Oct 13, 2017

Choose a reason for hiding this comment

robtpaton Oct 13, 2017

Choose a reason for hiding this comment

cjihrig Oct 15, 2017

Choose a reason for hiding this comment

BridgeAR commented Oct 18, 2017

robtpaton commented Oct 19, 2017

Trott commented Oct 27, 2017

joyeecheung Oct 28, 2017

Choose a reason for hiding this comment

addaleax Oct 29, 2017

Choose a reason for hiding this comment

gireeshpunathil commented Oct 31, 2017

Trott commented Nov 1, 2017

Trott commented Nov 1, 2017 • edited Loading

Trott commented Nov 1, 2017

robtpaton commented Nov 2, 2017

robtpaton commented Oct 6, 2017 •

edited

Loading

Trott commented Nov 1, 2017 •

edited

Loading