Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] test: consolidate http2 tests in one file #16072

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions test/parallel/test-http2-server-destroy-before-additional.js

This file was deleted.

41 changes: 0 additions & 41 deletions test/parallel/test-http2-server-destroy-before-priority.js

This file was deleted.

40 changes: 0 additions & 40 deletions test/parallel/test-http2-server-destroy-before-push.js

This file was deleted.

40 changes: 0 additions & 40 deletions test/parallel/test-http2-server-destroy-before-respond.js

This file was deleted.

41 changes: 0 additions & 41 deletions test/parallel/test-http2-server-destroy-before-rst.js

This file was deleted.

31 changes: 0 additions & 31 deletions test/parallel/test-http2-server-destroy-before-shutdown.js

This file was deleted.

37 changes: 0 additions & 37 deletions test/parallel/test-http2-server-destroy-before-state.js

This file was deleted.

40 changes: 0 additions & 40 deletions test/parallel/test-http2-server-destroy-before-write.js

This file was deleted.

48 changes: 48 additions & 0 deletions test/parallel/test-http2-server-stream-session-destroy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');

const server = h2.createServer();

server.on(
'stream',
common.mustCall((stream) => {
const errorObj = {
type: Error,
code: 'ERR_HTTP2_INVALID_STREAM',
message: 'The stream has been destroyed'
};
stream.session.destroy();

// Test that stream.state getter returns an empty object
// when the stream session has been destroyed
assert.deepStrictEqual(Object.create(null), stream.state);

// Test that ERR_HTTP2_INVALID_STREAM is thrown while calling
// stream operations after the stream session has been destroyed
common.expectsError(() => stream.additionalHeaders(), errorObj);
common.expectsError(() => stream.priority(), errorObj);
common.expectsError(
() => stream.pushStream({}, common.mustNotCall()),
errorObj
);
common.expectsError(() => stream.respond(), errorObj);
common.expectsError(() => stream.rstStream(), errorObj);
common.expectsError(() => stream.write('data'), errorObj);
})
);

server.listen(
0,
common.mustCall(() => {
const client = h2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.resume();
req.on('end', common.mustCall(() => server.close()));
})
);