Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Test Benchmark for es #16076

Closed
wants to merge 1 commit into from
Closed

Added Test Benchmark for es #16076

wants to merge 1 commit into from

Conversation

Ethan-Arrowood
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

es

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 8, 2017
@Trott
Copy link
Member

Trott commented Oct 12, 2017

It looks like this includes unrelated whitespace changes to tools/lint-js.js. Can you remove those changes (or else explain their relevance)?

Totally minor nit you can ignore if you wish: We usually put a comment before case '': explaining that it's a default for tests. (Take a look at some other benchmarks for examples.) It might be good to include a one-liner comment like that for each case '':.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2017
@Trott Trott force-pushed the Add/Test-Benchmark-Es branch from 9ba3fe2 to 3d8ade8 Compare October 12, 2017 17:29
@Trott
Copy link
Member

Trott commented Oct 12, 2017

I squashed the commits into one so that it git am would run cleanly when landing. (rebase and am were giving me issues trying to test. It also probably would have caused problems in CI which I"m about to start.)

Hope that's OK!

@Trott Trott force-pushed the Add/Test-Benchmark-Es branch 2 times, most recently from 2c41f41 to ae1bb46 Compare October 12, 2017 17:32
@Trott
Copy link
Member

Trott commented Oct 12, 2017

Nice work! We're really close!

The match benchmark is really slow compared to the others. It's super fast if we do this in the test file on lines 10 and 11:

               'millions=0.000001',
               'count=1',

Normally, I'd leave that as a comment but since I'm already messing around with your stuff to squash commits and whatnot, I'll go ahead and make that change myself. Leaving a comment so you or someone else can say "no no no, that's not right because of this other thing you're not seeing" or something in case I'm messing things up somehow. :-D

@Ethan-Arrowood @Trott
Test file edited. Update benchmarks for defaults
a457a5e 
Added parallel test benchmark for es
@Trott Trott force-pushed the Add/Test-Benchmark-Es branch from ae1bb46 to a457a5e Compare October 12, 2017 17:38
@Trott
Copy link
Member

Trott commented Oct 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10658/

@Ethan-Arrowood
Copy link
Contributor Author

@Trott thank you for all the input!

@Trott
Copy link
Member

Trott commented Oct 12, 2017

Only failure in CI is an unrelated known issue.

jasnell pushed a commit that referenced this pull request Oct 13, 2017
@Ethan-Arrowood @jasnell
test: add benchmark tests for es
af49e58 
Added parallel test benchmark for es

PR-URL: #16076
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

landed in af49e58

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@Ethan-Arrowood @addaleax
test: add benchmark tests for es
c078998 
Added parallel test benchmark for es

PR-URL: nodejs/node#16076
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@Ethan-Arrowood @targos
test: add benchmark tests for es
f1b4e7c 
Added parallel test benchmark for es

PR-URL: #16076
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ethan-Arrowood @Trott @jasnell @MylesBorins @nodejs-github-bot