doc: remove bold typography from STYLE_GUIDE.md #16085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
approved these changes
Oct 8, 2017
joyeecheung
approved these changes
Oct 8, 2017
doc/STYLE_GUIDE.md
Outdated
| * Underscores in filenames are allowed only when they are present in the | ||
| topic the document will describe (e.g., `child_process`). | ||
| * Filenames should be **lowercase**. | ||
| * Filenames should be lowercase. |
There was a problem hiding this comment.
While you are at it, I think this should be should be in lowercases or should be lowercased?
There was a problem hiding this comment.
Should I take it out entirely because line 4 already says that the filename should be lowercase? (That line should be reworded a bit too. If nothing else, it should say filenames rather than files.)
There was a problem hiding this comment.
Yeah I think this line seems unnecessary. As for the line above, Those files should be named like `lowercase-with-dashes.md`?
There was a problem hiding this comment.
Removed this line and edited line 4.
Remove unnecessary bold typography from the style guide.
|
✅ LGTM |
hiroppy
approved these changes
Oct 9, 2017
refack
approved these changes
Oct 9, 2017
gibfahn
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 9, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 10, 2017
Remove unnecessary bold typography from the style guide. PR-URL: nodejs#16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
|
Landed in a206bab |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Remove unnecessary bold typography from the style guide. PR-URL: nodejs/node#16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Remove unnecessary bold typography from the style guide. PR-URL: #16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
Remove unnecessary bold typography from the style guide. PR-URL: #16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Remove unnecessary bold typography from the style guide. PR-URL: #16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Remove unnecessary bold typography from the style guide. PR-URL: #16085 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary bold typography from the style guide.
Checklist
Affected core subsystem(s)
doc