test: allow short benchmarks for tests #16097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable short benchmarks for process and path benchmark tests. These have been observed to fail in CI due to returning with zero operations performed in the allotted time. We have a special environment variable for other benchmark tests that can be set to make that allowable in benchmarks. Set it for path and process.
Trott
added
benchmark
evanlucas
approved these changes
Oct 9, 2017
JungMinu
approved these changes
Oct 9, 2017
gibfahn
approved these changes
Oct 9, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
Enable short benchmarks for process and path benchmark tests. These have been observed to fail in CI due to returning with zero operations performed in the allotted time. We have a special environment variable for other benchmark tests that can be set to make that allowable in benchmarks. Set it for path and process. PR-URL: nodejs#16097 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in 067d1f1 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Enable short benchmarks for process and path benchmark tests. These have been observed to fail in CI due to returning with zero operations performed in the allotted time. We have a special environment variable for other benchmark tests that can be set to make that allowable in benchmarks. Set it for path and process. PR-URL: nodejs/node#16097 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Enable short benchmarks for process and path benchmark tests. These have been observed to fail in CI due to returning with zero operations performed in the allotted time. We have a special environment variable for other benchmark tests that can be set to make that allowable in benchmarks. Set it for path and process. PR-URL: #16097 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable short benchmarks for process and path benchmark tests. These have
been observed to fail in CI due to returning with zero operations
performed in the allotted time. We have a special environment variable
for other benchmark tests that can be set to make that allowable in
benchmarks. Set it for path and process.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark