-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: correct minor typo in lttng help message #16101
Conversation
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux)
If this is for consistency with Line 888 in 84579b1
why not change that line so it matches? -raise Exception('lttng is only supported on Linux.')
+raise Exception('Lttng is only available on Linux.') |
I was mainly thinking of the |
it just seems weird for the help to say:
and the error to say:
Why not make them both |
Ah I see now. I've updated it to supported. Thanks |
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: nodejs#16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Landed in 6cc4cf7 |
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: nodejs/node#16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: #16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: #16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: #16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: #16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available to Linux) This commit makes the help message consistent with the error message that is raised if --with-lttng is used on a non-Linux operating system: $ ./configure --help | grep 'with-lttng' --with-lttng build with Lttng (Only available on Linux) PR-URL: #16101 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Currently the help message when using --with-lttng looks like this:
This commit makes the help message consistent with the error message
that is raised if --with-lttng is used on a non-Linux operating
system:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build