test: reduce run time for string_decoder benchmark #16118
Conversation
test-benchmark-string_decoder was timing out in CI. Reduce the run time by sending appropriate options such that each benchmark file only runs one combination of options.
Trott
added
benchmark
|
Pinging @nodejs/testing for reviews. Would like to expedite landing so things like this from https://ci.nodejs.org/job/node-test-commit-smartos/12035/nodes=smartos15-64/console stop happening: not ok 206 parallel/test-benchmark-string_decoder
---
duration_ms: 120.743
severity: fail
stack: |-
timeout |
|
For reference, new CI: |
|
@Trott do we in general really want to have the benchmark coverage? I know we had a few ones that had issues but in general this is slowing down the CI and local testing a lot. |
@BridgeAR I'm in favor of it, but it's our collective decision, so if lots of others feel differently, then we can put them in |
|
By the way, this test (in parallel) now takes 5 seconds when it was timing out more than 2 minutes, so this fix will go a long way towards reducing the time these benchmark tests are taking. :-D |
|
Change seems trivial, easy to revert, low risk, and high value in the "turn CI not-red" department, so I'm going to land now.... |
test-benchmark-string_decoder was timing out in CI. Reduce the run time by sending appropriate options such that each benchmark file only runs one combination of options. PR-URL: nodejs#16118 Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in fa265a2 |
test-benchmark-string_decoder was timing out in CI. Reduce the run time by sending appropriate options such that each benchmark file only runs one combination of options. PR-URL: nodejs/node#16118 Reviewed-By: Refael Ackermann <refack@gmail.com>
test-benchmark-string_decoder was timing out in CI. Reduce the run time by sending appropriate options such that each benchmark file only runs one combination of options. PR-URL: #16118 Reviewed-By: Refael Ackermann <refack@gmail.com>
test-benchmark-string_decoder was timing out in CI. Reduce the run time
by sending appropriate options such that each benchmark file only runs
one combination of options.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark string_decoder