Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, test: escape script filename on Windows #16124

Closed
wants to merge 1 commit into from
Closed

win, test: escape script filename on Windows #16124

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Oct 10, 2017

Escape backslashes in script filename on Windows in test-cli-eval.js.

Fixes: #16057 and #16023

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@bzoz
win, test: escape script filename on Windows
8f87a8a 
Escape backslashes in script filename on Windows in a CLI test.

Fixes: nodejs#16057
Fixes: nodejs#16023
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 10, 2017
@bzoz
Copy link
Contributor Author

bzoz commented Oct 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10580/

@mscdex mscdex added the cli Issues and PRs related to the Node.js command line interface. label Oct 10, 2017
@vsemozhetbyt vsemozhetbyt added the windows Issues and PRs related to the Windows platform. label Oct 11, 2017
jasnell pushed a commit that referenced this pull request Oct 13, 2017
@bzoz @jasnell
test: escape script filename on Windows
07ec10d 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

Landed in 07ec10d

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@bzoz @addaleax
test: escape script filename on Windows
b854a72 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: nodejs/node#16124
Fixes: nodejs/node#16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@bzoz @targos
test: escape script filename on Windows
e3ac7b1 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
5f7469a 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
548b74c 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
04f3f6d 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@jasnell jasnell jasnell approved these changes

@Qard Qard Qard approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
9 participants
@bzoz @jasnell @digitalinfinity @Qard @watilde @mscdex @MylesBorins @vsemozhetbyt @nodejs-github-bot