build: restore $(CI_JS_SUITES) to test-ci-js #16132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
CI on |
|
/cc @bcoe 😉 |
gibfahn
approved these changes
Oct 10, 2017
|
@refack looks good to me, I think I screwed that up in a merge (since that was the whole darn point of pulling things into the |
3 tasks
|
Now this also fixes #16129 |
|
CI: https://ci.nodejs.org/job/node-test-commit/13005/ Intending to land tomorrow morning if there are now objections, since we're missing test coverage of the addons. |
bcoe
reviewed
Oct 10, 2017
| @@ -372,7 +372,7 @@ test-ci: | clear-stalled build-addons build-addons-napi | |||
| out/Release/cctest --gtest_output=tap:cctest.tap | |||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ | |||
| --mode=release --flaky-tests=$(FLAKY_TESTS) \ | |||
| $(TEST_CI_ARGS) $(CI_ASYNC_HOOKS) $(CI_JS_SUITES) known_issues | |||
| $(TEST_CI_ARGS) $(CI_ASYNC_HOOKS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) known_issues | |||
There was a problem hiding this comment.
something I just noticed, could you switch:
CI_NATIVE_SUITES := addons addons-napi
to
CI_NATIVE_SUITES ?= addons addons-napi
while you're at it; that would allow this set of tests to be more easily turned off when running coverage locally. tldr; I think this file got slightly screwed up during rebase.
Qard
approved these changes
Oct 11, 2017
mhdawson
approved these changes
Oct 11, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak
refack
force-pushed
the
small-makefile-fix
branch
from
e3614bd to
fc38604
Compare
refack
added a commit
to refack/node
that referenced
this pull request
Oct 12, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs#16132 Fixes: nodejs#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin E. Coe <ben@npmjs.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs/node#16132 Fixes: nodejs/node#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin E. Coe <ben@npmjs.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin E. Coe <ben@npmjs.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin E. Coe <ben@npmjs.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
@refack should we backport to 6.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(CI_JS_SUITES)was dropped during the last commit by a mistakeFixes: #16129
Fixes: nodejs/build#910
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build