Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncWrap minor fixes #1614

Closed
wants to merge 4 commits into from
Closed

AsyncWrap minor fixes #1614

wants to merge 4 commits into from

Commits on May 4, 2015

  1. async-wrap: don't call init callback unnecessarily 

    Some calls to ReqWrap would get through the initial check and allow the
init callback to run, even though the callback had not been used on the
parent. Fix by explicitly checking if the parent has a queue.

Also change the name of the check, and internal field of AsyncHooks.
Other names were confusing.
    @trevnorris
    trevnorris committed May 4, 2015
    Configuration menu
    Copy the full SHA
    3f51590 View commit details
    Browse the repository at this point in the history

  2. async-wrap: pass PROVIDER as first arg to init 

    Allow the init callback to see the PROVIDER type easily by being able to
compare the flag with the list of providers on the exported async_wrap
object.
    @trevnorris
    trevnorris committed May 4, 2015
    Configuration menu
    Copy the full SHA
    cc0385e View commit details
    Browse the repository at this point in the history

  3. async-wrap: set flags using functions 

    Setting flags using cryptic numeric object fields is confusing. Instead
use much simpler .enable()/.disable() calls on the async_wrap object.
    @trevnorris
    trevnorris committed May 4, 2015
    Configuration menu
    Copy the full SHA
    7740d5e View commit details
    Browse the repository at this point in the history

  4. async-wrap: remove before/after calls in init 

    It doesn't make sense to call before/after callbacks in init to the
parent because they'll be made anyway from MakeCallback. If information
does need to be propagated then it should be done automatically. Will
deal with this if the issue arrises in the future.
    @trevnorris
    trevnorris committed May 4, 2015
    Configuration menu
    Copy the full SHA
    eed38b3 View commit details
    Browse the repository at this point in the history