Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused includes from node_wrap.h #16179

Closed
wants to merge 1 commit into from
Closed

src: remove unused includes from node_wrap.h #16179

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 13, 2017

I cannot find any usages of these includes and think they can be
removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 13, 2017
@danbev
Copy link
Contributor Author

danbev commented Oct 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10679/

@mscdex
Copy link
Contributor

mscdex commented Oct 13, 2017

Minor nit: 'includeds' should probably be 'includes' in the commit message

@danbev
src: remove unused includes from node_wrap.h
02f8cda 
I cannot find any usages of these includes and think they can be
removed.
@danbev
Copy link
Contributor Author

danbev commented Oct 13, 2017

Minor nit: 'includeds' should probably be 'includes' in the commit message

Indeed, I'll fix that. Thanks!

@danbev danbev force-pushed the unused-includes-node_wrap.h branch from f136a1d to 02f8cda Compare October 13, 2017 15:49
@danbev danbev changed the title src: remove unused includeds from node_wrap.h src: remove unused includes from node_wrap.h Oct 13, 2017
@Trott
Copy link
Member

Trott commented Oct 13, 2017

CI did not run any subtasks. (There's a problem that @nodejs/build may or may not have fixed by now.) It will need to be re-run.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10723/

jasnell pushed a commit that referenced this pull request Oct 15, 2017
@danbev @jasnell
src: remove unused includes from node_wrap.h
75f154b 
I cannot find any usages of these includes and think they can be
removed.

PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 15, 2017

Landed in 75f154b

@jasnell jasnell closed this Oct 15, 2017
targos pushed a commit that referenced this pull request Oct 18, 2017
@danbev @targos
src: remove unused includes from node_wrap.h
659dd8a 
I cannot find any usages of these includes and think they can be
removed.

PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@danbev @addaleax
src: remove unused includes from node_wrap.h
050def5 
I cannot find any usages of these includes and think they can be
removed.

PR-URL: nodejs/node#16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev deleted the unused-includes-node_wrap.h branch November 16, 2017 08:36
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

danbev added a commit to danbev/node that referenced this pull request Nov 17, 2017
@danbev
src: remove unused includes from node_wrap.h
bb9df3e 
I cannot find any usages of these includes and think they can be
removed.

PR-URL: nodejs#16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev mentioned this pull request Nov 17, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@danbev @MylesBorins
src: remove unused includes from node_wrap.h
e67a377 
I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@danbev @MylesBorins
src: remove unused includes from node_wrap.h
ae3ad55 
I cannot find any usages of these includes and think they can be
removed.

Backport-PR-URL: #17092
PR-URL: #16179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @mscdex @Trott @joyeecheung @jasnell @MylesBorins @cjihrig @gireeshpunathil @nodejs-github-bot