build,win: include addons-napi in linter #16181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently test/addons-napi files are not being included in the lint processing. This commit adds them.
nodejs-github-bot
added
build
bnoordhuis
reviewed
Oct 13, 2017
vcbuild.bat
Outdated
| @@ -502,6 +502,9 @@ if %errorlevel% equ 0 goto exit | |||
| echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.cc" | |||
| if %errorlevel% equ 0 goto exit | |||
|
|
|||
| echo %1 | findstr /c:"test\\addons-napi\common.h" | |||
There was a problem hiding this comment.
Shouldn't that be "test\\addons-napi\\common.h"? (Note the second double slash.)
There was a problem hiding this comment.
Oh yes I should, sorry missed that. I'll update. Thanks
jasnell
approved these changes
Oct 13, 2017
bnoordhuis
approved these changes
Oct 14, 2017
cjihrig
approved these changes
Oct 14, 2017
test/windows-fanned unstable report looks unrelatedChecking ^not ok
c:\workspace\node-test-binary-windows\test.tap:
not ok 468 inspector/test-bindings # TODO : Fix flaky test
not ok 469 inspector/test-debug-end # TODO : Fix flaky test
Build step 'Jenkins Text Finder' changed build result to UNSTABLE
Notifying upstream projects of job completion
Finished: UNSTABLE |
danbev
added a commit
to danbev/node
that referenced
this pull request
Oct 16, 2017
Currently test/addons-napi files are not being included in the lint processing. This commit adds them. PR-URL: nodejs#16181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 7832e69 |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Currently test/addons-napi files are not being included in the lint processing. This commit adds them. PR-URL: #16181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
Currently test/addons-napi files are not being included in the lint processing. This commit adds them. PR-URL: nodejs/node#16181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, windows