Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage for process.umask #16188

Closed
wants to merge 1 commit into from
Closed

test: improve coverage for process.umask #16188

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@evanlucas
test: improve coverage for process.umask
f5e3cfe 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 13, 2017
@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10697/

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Oct 14, 2017
@lance
Copy link
Member

lance commented Oct 15, 2017

Two unrelated errors in CI. I'm going to go ahead and land this.

git-nodesource-update-reference 
Building remotely on test-requireio_mcollina-debian7-arm_pi2-1 (pi2-raspbian-wheezy) in workspace /home/iojs/build/workspace/git-nodesource-update-reference
FATAL: Failed to mkdirs: /home/iojs/build/workspace/git-nodesource-update-reference@tmp/secretFiles/d92beaa6-c864-4d5d-b809-3cdf13e4205f
java.io.IOException: Failed to mkdirs: /home/iojs/build/workspace/git-nodesource-update-reference@tmp/secretFiles/d92beaa6-c864-4d5d-b809-3cdf13e4205f
	at hudson.FilePath.mkdirs(FilePath.java:1171)
	at org.jenkinsci.plugins.credentialsbinding.impl.UnbindableDir.create(UnbindableDir.java:55)
	at org.jenkinsci.plugins.credentialsbinding.impl.AbstractOnDiskBinding.bindSingle(AbstractOnDiskBinding.java:38)
	at org.jenkinsci.plugins.credentialsbinding.Binding.bind(Binding.java:150)
	at org.jenkinsci.plugins.credentialsbinding.impl.SecretBuildWrapper.setUp(SecretBuildWrapper.java:96)
	at hudson.model.Build$BuildExecution.doRun(Build.java:157)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:496)
	at hudson.model.Run.execute(Run.java:1737)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:421)
Notifying upstream projects of job completion
Finished: FAILURE
node-test-binary-arm
All tests failed with similar filesystem errors. 
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-11664-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmp
fatal: Couldn't find remote ref refs/heads/jenkins-node-test-commit-arm-fanned-11664-binary-pi1p/cc-armv6
fatal: The remote end hung up unexpectedly

real	0m14.227s

user	0m0.330s

sys	0m0.170s


    

  • echo Could not fetch refs/heads/jenkins-node-test-commit-arm-fanned-11664-binary-pi1p/cc-armv6 from the local reference repo, trying GitHub.
    
Could not fetch refs/heads/jenkins-node-test-commit-arm-fanned-11664-binary-pi1p/cc-armv6 from the local reference repo, trying GitHub.
    • 

  • grep -q '^github.com' /home/iojs/.ssh/known_hosts
    • 

  • ssh-agent sh -c 'ssh-add **** && git fetch --no-tags git@github.com:janeasystems/node_binary_tmp.git +refs/heads/jenkins-node-test-commit-arm-fanned-11664-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmp'
    
Identity added: **** (****)

@lance
Copy link
Member

lance commented Oct 15, 2017

Landed in d43e7f3

@lance lance closed this Oct 15, 2017
lance pushed a commit that referenced this pull request Oct 15, 2017
@evanlucas @lance
test: improve coverage for process.umask
d43e7f3 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@evanlucas evanlucas deleted the test-umask branch October 16, 2017 13:06
targos pushed a commit that referenced this pull request Oct 18, 2017
@evanlucas @targos
test: improve coverage for process.umask
45ccf5c 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@evanlucas @addaleax
test: improve coverage for process.umask
484e77a 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: nodejs/node#16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@evanlucas @MylesBorins
test: improve coverage for process.umask
68a2a9f 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@evanlucas @MylesBorins
test: improve coverage for process.umask
8e04c55 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@evanlucas @MylesBorins
test: improve coverage for process.umask
1fe3e86 
This ensures that process.umask() throws with the correct error when
invalid inputs are supplied.

PR-URL: #16188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@hiroppy hiroppy hiroppy approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.