Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable (sensible) additional eslint rules #16243

Closed
wants to merge 3 commits into from
Closed

tools: enable (sensible) additional eslint rules #16243

wants to merge 3 commits into from

Commits on Oct 16, 2017

  1. test: disable accessor-pairs in test-util-inspect

    @apapirovski
    apapirovski committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    7b00944 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2017

  1. lib: fix eslint no-lonely-if

    @apapirovski
    apapirovski committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    bda0695 View commit details
    Browse the repository at this point in the history

  2. tools: enable additional eslint rules 

    Enable additional rules that node either already adheres to
or it makes sense to do so going forward: for-direction,
accessor-pairs, no-lonely-if and symbol-description.

Refs: https://eslint.org/docs/rules/for-direction
Refs: https://eslint.org/docs/rules/accessor-pairs
Refs: https://eslint.org/docs/rules/no-lonely-if
Refs: https://eslint.org/docs/rules/symbol-description
    @apapirovski
    apapirovski committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    99fe59e View commit details
    Browse the repository at this point in the history