Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --without-intl #16250

Closed
wants to merge 2 commits into from
Closed

Fix --without-intl #16250

wants to merge 2 commits into from

Conversation

TimothyGu
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src, benchmark

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 17, 2017
@TimothyGu
Copy link
Member Author

As if that issue needs more references: nodejs/build#419

@mscdex mscdex added i18n-api Issues and PRs related to the i18n implementation. build Issues and PRs related to build files or the CI. labels Oct 17, 2017
@TimothyGu TimothyGu mentioned this pull request Oct 17, 2017
Closed
3 tasks
@TimothyGu
Copy link
Member Author

Oops, created a branch on nodejs/node. Correct PR: #16251

@TimothyGu TimothyGu closed this Oct 17, 2017
@TimothyGu TimothyGu deleted the no-icu-fix branch October 17, 2017 06:25
@TimothyGu TimothyGu mentioned this pull request Oct 20, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyGu @mscdex @nodejs-github-bot