-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: remove no-longer-relevant comment #16285
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code.
nodejs-github-bot
added
the
fs
Issues and PRs related to the fs subsystem / file system.
label
Oct 18, 2017
bnoordhuis
approved these changes
Oct 18, 2017
lpinca
approved these changes
Oct 18, 2017
refack
approved these changes
Oct 18, 2017
Context: written in 1 Mar 2010 by @ry - Lines 59 to 69 in 810882c
|
cjihrig
approved these changes
Oct 18, 2017
evanlucas
approved these changes
Oct 18, 2017
daxlab
approved these changes
Oct 18, 2017
jasnell
approved these changes
Oct 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this does not need to wait the 48 hours to land
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2017
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code. PR-URL: #16285 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 3e14449 |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code. PR-URL: #16285 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code. PR-URL: nodejs/node#16285 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
The comment suggests that the subsequent code could by DRYed up, due to simply passing arguments along. However, in the commits since then, this no longer appears to apply, and so the comment is now confusing with respect to the current code. PR-URL: nodejs/node#16285 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment suggests that the subsequent code could by DRYed up, due to
simply passing arguments along. However, in the commits since then, this
no longer appears to apply, and so the comment is now confusing with
respect to the current code.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
fs