Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build, windows: use /MP for debug builds #16333

Merged
merged 0 commits into from
Oct 21, 2017
Merged

build, windows: use /MP for debug builds #16333

merged 0 commits into from
Oct 21, 2017

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Oct 20, 2017

Makes debug builds much faster. 🚀

/MP was intentionally disabled for debug builds in 16788f4, but they forgot to include the PR-URL, so I can't find the discussion that led to this decision. Probably no longer relevant.

Checklist
Affected core subsystem(s)

build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 20, 2017
@seishun seishun requested a review from refack October 20, 2017 08:20
@seishun seishun added the windows Issues and PRs related to the Windows platform. label Oct 20, 2017
bnoordhuis
bnoordhuis approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works. I don't remember why /MP was disabled although I do remember that commit.

@tniessen
Copy link
Member

Might be nodejs/node-v0.x-archive#1471.

cjihrig
cjihrig approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works.

@tniessen
Copy link
Member

From the PR I referenced above:

Makes debug builds into true (non-optimized) debug builds

They might have misinterpreted /MP to affect the result instead of the build process.

@Fishrock123
Copy link
Contributor

16788f4, but they forgot to include the PR-URL

That was long before PR-URL existed. 😉

@seishun seishun closed this Oct 21, 2017
@seishun seishun merged commit 6874249 into nodejs:master Oct 21, 2017
@seishun seishun deleted the mp branch October 21, 2017 10:07
@seishun
Copy link
Contributor Author

seishun commented Oct 21, 2017

Landed in 5018156.

seishun added a commit that referenced this pull request Oct 21, 2017
@seishun
build,win: use /MP for debug builds
5018156 
PR-URL: #16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@seishun seishun mentioned this pull request Oct 21, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@seishun @MylesBorins
build,win: use /MP for debug builds
3951c15 
PR-URL: #16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@seishun @addaleax
build,win: use /MP for debug builds
98ceef2 
PR-URL: nodejs/node#16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@seishun @MylesBorins
build,win: use /MP for debug builds
824d974 
PR-URL: #16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins
Copy link
Contributor

This landed cleanly on v6.x, please lmk if I should back it out

/cc @nodejs/platform-windows

@seishun
Copy link
Contributor Author

seishun commented Nov 16, 2017

If you're going to land #16415 as well, then it's good. Otherwise it should be backed out.

@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@seishun @MylesBorins
build,win: use /MP for debug builds
e333505 
PR-URL: #16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@seishun @MylesBorins
build,win: use /MP for debug builds
a14f564 
PR-URL: #16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@seishun @addaleax
build,win: use /MP for debug builds
d4f5ba7 
PR-URL: nodejs/node#16333
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@seishun @tniessen @Fishrock123 @MylesBorins @refack @bnoordhuis @jasnell @cjihrig @nodejs-github-bot