wrap_js_stream: adding test for readStop #16356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Oct 22, 2017
jasnell
approved these changes
Oct 22, 2017
apapirovski
approved these changes
Oct 22, 2017
| const fakeStreamObj = new FakeStream(); | ||
| const wrappedStream = new WrappedStream(fakeStreamObj); | ||
|
|
||
| assert.strictEqual(fakeStreamObj.isPaused(), false, 'Resume by wrapped stream'); |
There was a problem hiding this comment.
I feel like the assert message here and in all the other instances below might be more confusing than helpful. I would just remove them and have it be the default assertion message.
Instead, comments could be added to explain all the stages of this process and what exactly is being tested.
|
|
||
| require('../common'); | ||
| const assert = require('assert'); | ||
| const WrappedStream = require('internal/wrap_js_stream'); |
There was a problem hiding this comment.
Could this be renamed to StreamWrap for consistency with the rest of the codebase?
gibfahn
approved these changes
Oct 23, 2017
apapirovski
pushed a commit
that referenced
this pull request
Oct 26, 2017
PR-URL: #16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
This is failing on v8.x-staging with: Should this be backported to |
2 tasks
gibfahn
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16356 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test for wrap_js_stream readStop method that was skipped in coverage
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
wrap_js_stream