Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace rstStreamWithCancel with rstWithCancel #16365

Closed
wants to merge 1 commit into from
Closed

replace rstStreamWithCancel with rstWithCancel #16365

wants to merge 1 commit into from

Conversation

c0b
Copy link
Contributor

@c0b c0b commented Oct 21, 2017

there's no such method called rstStreamWithCancel; should be a typo of rstWithCancel

@c0b
replace rstStreamWithCancel with rstWithCancel
496f845 
there's no such method called rstStreamWithCancel; should be a typo of rstWithCancel
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Oct 21, 2017
apapirovski pushed a commit that referenced this pull request Oct 23, 2017
@c0b @apapirovski
doc: fix http2 example with rstWithCancel
ba4a0a6 
Replace the non-existent method rstStreamWithCancel with rstWithCancel

PR-URL: #16365
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@apapirovski
Copy link
Member

Landed in ba4a0a6

@c0b Thank you for improving node & congrats on becoming a Contributor! 🎉

MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@c0b @MylesBorins
doc: fix http2 example with rstWithCancel
73915d3 
Replace the non-existent method rstStreamWithCancel with rstWithCancel

PR-URL: #16365
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@c0b @addaleax
doc: fix http2 example with rstWithCancel
3864209 
Replace the non-existent method rstStreamWithCancel with rstWithCancel

PR-URL: nodejs/node#16365
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@c0b @addaleax
doc: fix http2 example with rstWithCancel
73a252e 
Replace the non-existent method rstStreamWithCancel with rstWithCancel

PR-URL: nodejs/node#16365
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@c0b @apapirovski @jasnell @cjihrig @joyeecheung @MylesBorins @nodejs-github-bot