Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix compiler errors in debug statements #16373

Closed
wants to merge 1 commit into from
Closed

http2: fix compiler errors in debug statements #16373

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Oct 21, 2017 •
edited
Loading

When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. I'm not certain if this is something about my system or if I'm missing something here since no one else has noticed... then again maybe I'm the only one using --debug-http2 at this moment.

../src/node_http2.cc:141:17: error: cannot pass object of non-trivial type 'node::AliasedBuffer<unsigned int,
      v8::Uint32Array>::Reference' through variadic function; call will abort at runtime [-Wnon-pod-varargs]
                buffer[IDX_SETTINGS_HEADER_TABLE_SIZE]);

This fixes the issue by casting to uint32_t.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@apapirovski
http2: fix errors in debug statements
197c8e8 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.
@apapirovski apapirovski added the http2 Issues or PRs related to the http2 subsystem. label Oct 21, 2017
@apapirovski apapirovski requested a review from jasnell October 21, 2017 23:58
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Oct 21, 2017
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10893/

jasnell
jasnell approved these changes Oct 22, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what os are you building on?

@apapirovski
Copy link
Member Author

@jasnell I'm on macOS 10.12.6.

@jasnell
Copy link
Member

jasnell commented Oct 22, 2017

Ok. I haven't built on Mac with the --debug-http2 option in quite some time. Thanks for catching that! :)

apapirovski added a commit that referenced this pull request Oct 24, 2017
@apapirovski
http2: fix errors in debug statements
47ed02c 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.

PR-URL: #16373
Reviewed-By: James M Snell <jasnell@gmail.com>
@apapirovski
Copy link
Member Author

Landed in 47ed02c

@apapirovski apapirovski deleted the patch-http2-fix-debug branch October 24, 2017 16:08
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@apapirovski @addaleax
http2: fix errors in debug statements
aa8ebaa 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.

PR-URL: nodejs/node#16373
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@apapirovski @gibfahn
http2: fix errors in debug statements
342124e 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.

PR-URL: #16373
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@apapirovski @gibfahn
http2: fix errors in debug statements
3638694 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.

PR-URL: #16373
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@apapirovski @addaleax
http2: fix errors in debug statements
98df0e5 
When compiling with --debug-http2 flag, compiler complains
about passing wrong type of argument to DEBUG_HTTP2. Fix
by using static_cast to uint32_t.

PR-URL: nodejs/node#16373
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apapirovski @jasnell @nodejs-github-bot