Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for prop interceptors on sandbox #16409

Closed
wants to merge 1 commit into from
Closed

test: add test for prop interceptors on sandbox #16409

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 23, 2017

Refs: #16293

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

vm

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 23, 2017
@targos targos added vm Issues and PRs related to the vm subsystem. dont-land-on-v4.x labels Oct 23, 2017
@targos
Copy link
Member Author

targos commented Oct 23, 2017

/cc @fhinkel

fhinkel
fhinkel approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some of them are covered in other tests, but many cases are not explicitly covered.

They are good to have if we work on fixing #12300

@targos
Copy link
Member Author

targos commented Oct 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10926/

@targos
Copy link
Member Author

targos commented Oct 26, 2017

Landed in a37a0ad

@targos targos closed this Oct 26, 2017
@targos targos deleted the add-test-context branch October 26, 2017 08:24
targos added a commit that referenced this pull request Oct 26, 2017
@targos
test: add test for prop interceptors on sandbox
a37a0ad 
PR-URL: #16409
Refs: #16293
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@targos @addaleax
test: add test for prop interceptors on sandbox
914ab9c 
PR-URL: nodejs/node#16409
Refs: nodejs/node#16293
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@targos @addaleax
test: add test for prop interceptors on sandbox
1bca772 
PR-URL: nodejs/node#16409
Refs: nodejs/node#16293
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @fhinkel @jasnell @cjihrig @nodejs-github-bot