Included reference to 'constant time' in crypto.timingSafeEqual descr… #16604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
akeinhell
approved these changes
Oct 30, 2017
joyeecheung
approved these changes
Oct 30, 2017
joyeecheung
reviewed
Oct 30, 2017
doc/api/crypto.md
Outdated
| @@ -1969,6 +1969,7 @@ added: v6.6.0 | |||
| - `a` {Buffer | TypedArray | DataView} | |||
| - `b` {Buffer | TypedArray | DataView} | |||
|
|
|||
| This function is based on constant time algorithm. | |||
There was a problem hiding this comment.
Nit: based on a constant-time algorithm, or based on constant-time comparisons would be more grammatically correct..
There was a problem hiding this comment.
@joyeecheung : agree.. let me make the correction to based on a constant-time algorithm
There was a problem hiding this comment.
@joyeecheung : I've made the change. Please review. Thanks.
joyeecheung
approved these changes
Oct 30, 2017
…description The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. Fixes: #16604
|
@joyeecheung : Thanks for pointing out the commit message format. I've fixed that. Kindly have a look now. Thank you. |
jasnell
approved these changes
Nov 2, 2017
|
Landed in 841e305, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Nov 2, 2017
Included reference to 'constant time' in crypto.timingSafeEqual description. The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. PR-URL: #16604 Fixes: #16504 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@joyeecheung : good to merge ? |
@mithunsasidharan This has already landed, if you look at 841e305 you'll see it's already on Node master. Github just doesn't show it as merged because the commit was rebased. Thanks for your contribution 🎉 ! |
|
@gibfahn @joyeecheung : Thanks much ! |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Included reference to 'constant time' in crypto.timingSafeEqual description. The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. PR-URL: nodejs#16604 Fixes: nodejs#16504 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Nov 14, 2017
Included reference to 'constant time' in crypto.timingSafeEqual description. The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. PR-URL: #16604 Fixes: #16504 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
Included reference to 'constant time' in crypto.timingSafeEqual description. The Node website would score higher on a Google search and the API would be more discoverable if it used the words "constant time" in its description. PR-URL: #16604 Fixes: #16504 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included reference to 'constant time' in crypto.timingSafeEqual description
Fixes : #16504