-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodejs/gyp team #16638
Add nodejs/gyp team #16638
Conversation
does this confirm #16633 (comment) ? |
Sort of. We could still upstream things to GYP itself, but whether we should keep doing that is something the members of nodejs/gyp could decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: nodejs#16638 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Team created, it could do with some more members though... |
Just noticed when looking at the teams page that there's now a "gyp" team as well as a "node-gyp" team. Should they be combined? |
node-gyp are people with write bit in https://github.com/nodejs/node-gyp (which is actually mostly node.js core around GYP). |
As @refack says, they are different teams with different purposes. |
PR-URL: nodejs#16638 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #16638 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
It would be good to have a GYP team to cc/ in issues.
I know @refack and @bnoordhuis have done a fair amount of work on GYP in the past, not sure who else has experience there, maybe @seishun ?
If you want to be on the team, reply here and I'll add you 😁 .
I also formatted the table while I was there. Happy to change it back if people prefer unevenness to long lines.
Checklist
Affected core subsystem(s)
doc, build