-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: try installing js-yaml only once #16661
Conversation
CI: https://ci.nodejs.org/job/node-test-pull-request/11126/ do we have a CI for running |
Failures look unrelated |
No, but we definitely should! |
Ping @nodejs/collaborators can someone review this? Thanks! |
@@ -561,15 +562,16 @@ gen-json = tools/doc/generate.js --format=json $< > $@ | |||
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \ | |||
--template=doc/template.html --analytics=$(DOCS_ANALYTICS) $< > $@ | |||
|
|||
gen-doc = \ | |||
install-yaml: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add install-yaml
to the list of phony targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does doc-targets
need to be added as well?
@nodejs/build |
pretty weird, I don't really understand why this makes a difference but if it works @joyeecheung then you can have my lgtm |
08e34e4
to
4c42f9d
Compare
Added js-yaml to the phony targets per @richardlau 's suggestion. PTAL. CI: https://ci.nodejs.org/job/node-test-pull-request/11373/
I am not quite sure either but I can be certain this is related to GNU make, because I can reproduce that bug with |
I think I have a rough idea about why this fixes the issue now, it probably has something to do with the The pis are not working properly at the moment, this just need a green arm CI before landing. |
Smart OS failed, possibly related to #17043 (this time the test/addons/ are missing builds) , still try again to be safe.. New SmartOS CI: https://ci.nodejs.org/job/node-test-commit-smartos/13195/ |
Landed in f24d961, thanks! |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
tools
Fixes: #16650