docs: warn users about non-ASCII paths on build #16735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
gibfahn
approved these changes
Nov 4, 2017
cjihrig
approved these changes
Nov 4, 2017
|
Apparently, #16047 addresses only Path used was: |
|
Ah, that's been fixed upstream (link) but hasn't made its way downstream yet. |
jasnell
approved these changes
Nov 8, 2017
|
Tested the upstream fix on Ubuntu 16.04 and Windows 10. Ubuntu is working, but Windows is still breaking:
Probably unrelated to #14336 as it seems to be a Windows-only problem with non-ASCII characters, I'll open a new issue for this. |
addaleax
reviewed
Dec 10, 2017
BUILDING.md
Outdated
| @@ -97,7 +97,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and | |||
| * After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) | |||
| to avoid popups asking to accept incoming network connections when running tests: | |||
|
|
|||
| If the path to your build directory contains a space, the build will likely fail. | |||
| If the path to your build directory contains a space or a non-ASCII character, the | |||
| build will likely fail. | |||
There was a problem hiding this comment.
I would not put this into the unix section, experiences from recent Code & Learn events have shown that we are not usually that far away from this working.
The only issue I know of is fixed by v8/v8@744b49e, which comes with the V8 6.4 upgrade (#17489).
There was a problem hiding this comment.
That makes sense.
PR updated with the warning removed from the Unix section, keeping it only on the Windows section
The build breaks if there's a non-ASCII character on the path to the building directory. Ref: nodejs#16278 Ref: nodejs#14336
mmarchini
force-pushed
the
nonascii-path-build-warning
branch
from
0a6f858 to
0e90f1a
Compare
joyeecheung
approved these changes
Jan 17, 2018
joyeecheung
added
the
author ready
|
Landed in c134ff2, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Jan 18, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
removed
the
author ready
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: #16735 Refs: #16278 Refs: #14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: nodejs#16735 Refs: nodejs#16278 Refs: nodejs#14336 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build breaks if there's a non-ASCII character on the path to the building
directory.
Ref: #16278
Ref: #14336
Checklist
Affected core subsystem(s)
doc