Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: multiple smaller code cleanups #16764

Closed
wants to merge 1 commit into from
Closed

http2: multiple smaller code cleanups #16764

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 5, 2017

  • Add Http2Priority utility class
  • Reduces some code duplication
  • Other small minor cleanups
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell
http2: multiple smaller code cleanups
55d5819 
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 5, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Nov 5, 2017
apapirovski
apapirovski approved these changes Nov 5, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Nov 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11366/

jasnell added a commit that referenced this pull request Nov 12, 2017
@jasnell
http2: multiple smaller code cleanups
36e9574 
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups

PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@jasnell
Copy link
Member Author

jasnell commented Nov 12, 2017

Landed in 36e9574

@jasnell jasnell closed this Nov 12, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@jasnell @evanlucas
http2: multiple smaller code cleanups
8dfd5a5 
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups

PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@jasnell @MylesBorins
http2: multiple smaller code cleanups
29efb02 
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups

PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @apapirovski @mscdex @MylesBorins @nodejs-github-bot