Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test to use fixtures #16799

Closed
wants to merge 1 commit into from
Closed

test: update test to use fixtures #16799

wants to merge 1 commit into from

Conversation

awegrzyn
Copy link
Contributor

@awegrzyn awegrzyn commented Nov 6, 2017

Update test to use fixtures

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11218/

@gireeshpunathil
Copy link
Member

I am assuming these originate from code&learn? Please confirm - so that they can be labelled so

@awegrzyn
Copy link
Contributor Author

awegrzyn commented Nov 6, 2017

Indeed, I've also submitted #16805

@apapirovski apapirovski added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@awegrzyn @Trott
test: update test to use fixtures
6fb5f64 
Update test-repl-require-context to use fixtures module.

PR-URL: nodejs#16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Landed in 6fb5f64.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@awegrzyn @cjihrig
test: update test to use fixtures
f3e63f2 
Update test-repl-require-context to use fixtures module.

PR-URL: nodejs#16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@awegrzyn @MylesBorins
test: update test to use fixtures
fb34e11 
Update test-repl-require-context to use fixtures module.

PR-URL: #16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@awegrzyn @MylesBorins
test: update test to use fixtures
480f14a 
Update test-repl-require-context to use fixtures module.

PR-URL: #16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@awegrzyn @MylesBorins
test: update test to use fixtures
cdfb0c7 
Update test-repl-require-context to use fixtures module.

PR-URL: #16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@awegrzyn @MylesBorins
test: update test to use fixtures
755f5e3 
Update test-repl-require-context to use fixtures module.

PR-URL: #16799
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@awegrzyn @Trott @gireeshpunathil @cjihrig @apapirovski @mscdex @MylesBorins @nodejs-github-bot