Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir with fixtures module #16803

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with fixtures module #16803

wants to merge 1 commit into from

Conversation

doomhz
Copy link

@doomhz doomhz commented Nov 6, 2017 •
edited
Loading

Require fixturesDir from fixtures module instead of common.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@doomhz
test: replace common.fixturesDir with fixtures module
f45a469 
Require `fixturesDir` from `fixtures` module instead of `common`.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11224/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@doomhz @Trott
test: replace common.fixturesDir with fixtures module
4de1027 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: nodejs#16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Landed in 4de1027.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@doomhz @cjihrig
test: replace common.fixturesDir with fixtures module
ec1b110 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: nodejs#16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@doomhz @MylesBorins
test: replace common.fixturesDir with fixtures module
0fa659c 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@doomhz @MylesBorins
test: replace common.fixturesDir with fixtures module
00cdc28 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@doomhz @MylesBorins
test: replace common.fixturesDir with fixtures module
065af13 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@doomhz @MylesBorins
test: replace common.fixturesDir with fixtures module
e7a456a 
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@doomhz @Trott @cjihrig @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot