Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test to use fixtures.readKey #16811

Closed
wants to merge 1 commit into from
Closed

test: update test to use fixtures.readKey #16811

wants to merge 1 commit into from

Conversation

darahayes
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines (leaving this unchecked because I'm not 100% sure - this is my first PR)
Affected core subsystem(s)

test: test/parallel/test-regress-GH-1531.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
cjihrig
cjihrig approved these changes Nov 6, 2017
View reviewed changes
test/parallel/test-regress-GH-1531.js Outdated
@@ -1,16 +1,19 @@
'use strict';
const common = require('../common');

// This test ensures that a http request callback is called
// when the agent option is set. See https://github.com/nodejs/node-v0.x-archive/issues/1531
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the See ... to a new line to stay under 80 characters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig No problem at all!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Nov 6, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11239/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
@Trott
test: update test to use fixtures.readKey
207b24a 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 207b24a.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@cjihrig
test: update test to use fixtures.readKey
ef67980 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
test: update test to use fixtures.readKey
5e4ce5c 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
test: update test to use fixtures.readKey
5719bea 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@MylesBorins
test: update test to use fixtures.readKey
d28737b 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@MylesBorins
test: update test to use fixtures.readKey
9f9e824 
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Trott Trott Trott approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@darahayes @Trott @apapirovski @cjihrig @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot