Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reuse existing PassThrough implementation #16936

Closed
wants to merge 1 commit into from
Closed

test: reuse existing PassThrough implementation #16936

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@tniessen tniessen added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Nov 10, 2017
@refack
Copy link
Contributor

refack commented Nov 10, 2017

@tniessen since you are already analysing this test, could you add the general description in it's header, so it'll be easy in the future to see what it's actually testing (for example that the old PassThrough is just a helper).

@tniessen
Copy link
Member Author

Rebased. After talking to @refack, I might add descriptions to multiple tests as soon as I get some time off, but probably not as part of this PR.

@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11428/

@tniessen
Copy link
Member Author

Landed in 6b351e9.

@tniessen tniessen closed this Nov 14, 2017
tniessen added a commit that referenced this pull request Nov 14, 2017
@tniessen
test: reuse existing PassThrough implementation
6b351e9 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 14, 2017
@tniessen @evanlucas
test: reuse existing PassThrough implementation
859abdb 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@tniessen @MylesBorins
test: reuse existing PassThrough implementation
659c458 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@tniessen @MylesBorins
test: reuse existing PassThrough implementation
efdd7c8 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tniessen @MylesBorins
test: reuse existing PassThrough implementation
3ad45d8 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tniessen @MylesBorins
test: reuse existing PassThrough implementation
f0eeddb 
PR-URL: #16936
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Mar 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @refack @jasnell @addaleax @lpinca @cjihrig @MylesBorins