Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) test: use ES6 classes instead of util.inherits #17068

Closed
wants to merge 1 commit into from
Closed

(v6.x backport) test: use ES6 classes instead of util.inherits #17068

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Backport of #16938 to v6.x.

Thanks to @MylesBorins for landing backport PRs required for this to land cleanly!

@tniessen
test: use ES6 classes instead of util.inherits
83169f0 
PR-URL: nodejs#16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@tniessen tniessen added test Issues and PRs related to the tests. v6.x labels Nov 16, 2017
@tniessen tniessen requested a review from MylesBorins November 16, 2017 11:53
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Nov 16, 2017
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14073/

MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
5793586 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins
Copy link
Contributor

landed in 5793586
thanks!

MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
9944499 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tniessen @MylesBorins
test: use ES6 classes instead of util.inherits
f2108fa 
Backport-PR-URL: #17068
PR-URL: #16938
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tniessen @MylesBorins @nodejs-github-bot