Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use executable + pid as inspector context id #17087

Merged
merged 2 commits into from
Nov 20, 2017
Merged

src: use executable + pid as inspector context id #17087

merged 2 commits into from
Nov 20, 2017

Commits on Nov 20, 2017

  1. src: abstract getpid() operation 

    There are a few places where we paper over the fact that getpid() is
called GetCurrentProcessId() on Windows.  Let's move it into a function.

PR-URL: nodejs#17087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    @bnoordhuis
    bnoordhuis committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    7dc35e9 View commit details
    Browse the repository at this point in the history

  2. src: inspector context name = program title + pid 

    Report (for example) "node[1337]" as the human-readable name rather
than the more generic and less helpful "Node.js Main Context."

While not perfect yet, it should be an improvement to people that
debug multiple processes from DevTools, VS Code, etc.

PR-URL: nodejs#17087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    @bnoordhuis
    bnoordhuis committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    f526deb View commit details
    Browse the repository at this point in the history