-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require-buffer lint fixer #17144
Closed
Closed
require-buffer lint fixer #17144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts).
Bamieh
changed the title
Fixes: https://github.com/nodejs/node/issues/16636
require-buffer lint fixer
Nov 20, 2017
targos
approved these changes
Nov 23, 2017
…er-require-buffer
hmm 🤔 i ran the tests on my machine (macOS) and everything is working fine, Update: After looking into the jenkins error logs
This does not seem an error caused from the code i've written |
@targos can we rerun the tests? |
|
addaleax
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Nov 28, 2017
Landed in 0319a5e |
addaleax
pushed a commit
that referenced
this pull request
Nov 28, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Adds `require-buffer` lint fixer. If the buffer module is not required while `Buffer` is used, require the `buffer` module. If the file has a `'use strict';` line, add the require after it on a separate line. If the file does not have any (currently impossible with the `strict` rule) add it after the first comment (before the real code starts). Fixes: #16636 PR-URL: #17144 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #16636 (adds the
require-buffer
lint fixer).If the
buffer
module is not required whileBuffer
is used, require thebuffer
module as follows:'use strict';
line, add the require after it on a separate line.strict
rule) add it after the first comment and before the real code starts.Checklist
Affected core subsystem(s)
tools