Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: be lazy when creating CJS facades #17153

Closed
wants to merge 2 commits into from
Closed

module: be lazy when creating CJS facades #17153

wants to merge 2 commits into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Nov 20, 2017

This should remove the penalty for loading CJS that is never imported.

Aside: We could probably do more low hanging optimizations if we could reuse facades.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

module

@bmeck
module: be lazy when creating CJS facades
5d6512e 
This should remove the penalty for loading CJS that is never imported.
@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Nov 20, 2017
Fishrock123
Fishrock123 approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with CI https://ci.nodejs.org/job/node-test-pull-request/11552/

@Fishrock123 Fishrock123 mentioned this pull request Nov 20, 2017
Closed
1 task
TimothyGu
TimothyGu approved these changes Nov 20, 2017
View reviewed changes
lib/module.js
ctx.reflect.exports.default.set(exports);
return ctx;
})
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: weird indentation

      ESMLoader.moduleMap.set(
        urlString,
        new ModuleJob(ESMLoader, url, async () => {
          const ctx = createDynamicModule(
            ['default'], url);
          ctx.reflect.exports.default.set(exports);
          return ctx;
        })
      );

Also I suppose the const exports = this.exports isn't needed as it's used in an arrow function only anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to save it due to timing difference.

@bmeck bmeck mentioned this pull request Nov 27, 2017
Closed
3 tasks
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/14414/

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@addaleax
Copy link
Member

Landed in 2219859

@addaleax addaleax closed this Nov 28, 2017
addaleax pushed a commit that referenced this pull request Nov 28, 2017
@bmeck @addaleax
module: be lazy when creating CJS facades
2219859 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@bmeck @MylesBorins
module: be lazy when creating CJS facades
d18d3e3 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@bmeck @MylesBorins
module: be lazy when creating CJS facades
0af011a 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@bmeck @MylesBorins
module: be lazy when creating CJS facades
06da8a7 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@bmeck @gibfahn
module: be lazy when creating CJS facades
da40417 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@bmeck @gibfahn
module: be lazy when creating CJS facades
371e3f1 
This should remove the penalty for loading CJS that is never imported.

PR-URL: #17153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bmeck @addaleax @jasnell @Fishrock123 @benjamingr @TimothyGu @cjihrig @gibfahn @nodejs-github-bot