Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of more not-nice terms #17170

Closed
wants to merge 2 commits into from
Closed

get rid of more not-nice terms #17170

wants to merge 2 commits into from
+5 −5

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Nov 21, 2017 •
edited
Loading

this was all i could find with ack and a bunch of not nice phrases and words

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
aqrln
aqrln approved these changes Nov 21, 2017
View reviewed changes
test/parallel/test-process-raw-debug.js Outdated
@@ -30,7 +30,7 @@ switch (process.argv[2]) {
case undefined:
return parent();
default:
throw new Error(`wtf? ${process.argv[2]}`);
throw new Error(`invalid! ${process.argv[2]}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe use a colon here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, colon will yield a cleaner message

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. net Issues and PRs related to the net subsystem. labels Nov 21, 2017
apapirovski
apapirovski approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nit from @aqrln fixed, also the commit message would ideally be updated to something like test: clean up inappropriate language or something.

aqrln
aqrln reviewed Nov 21, 2017
View reviewed changes
test/parallel/test-process-raw-debug.js Outdated
@@ -30,7 +30,7 @@ switch (process.argv[2]) {
case undefined:
return parent();
default:
throw new Error(`wtf? ${process.argv[2]}`);
throw new Error(`invalid; ${process.argv[2]}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being pedantic, but this is a semicolon, not a colon (:) 😄

mhdawson
mhdawson approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11592/

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017
@joyeecheung
Copy link
Member

Added fast-track although there are already a ton of approvals.

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 21, 2017
@aqrln
Copy link
Contributor

aqrln commented Nov 22, 2017

+1 to fast-tracking. I went ahead and fixed the nit myself. Gonna land it after the CI finishes green.

New CI: https://ci.nodejs.org/job/node-test-pull-request/11623/

@aqrln
Copy link
Contributor

aqrln commented Nov 22, 2017

Landed in 7fd8a21.

@aqrln aqrln closed this Nov 22, 2017
aqrln pushed a commit that referenced this pull request Nov 22, 2017
@devsnek @aqrln
test: clean up inappropriate language
7fd8a21 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@aqrln aqrln removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2017
@devsnek devsnek deleted the words branch November 22, 2017 15:05
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@devsnek @MylesBorins
test: clean up inappropriate language
c64d1cd 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@devsnek @MylesBorins
test: clean up inappropriate language
72e480d 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@devsnek @MylesBorins
test: clean up inappropriate language
0963c75 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@devsnek @gibfahn
test: clean up inappropriate language
861082a 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@devsnek @gibfahn
test: clean up inappropriate language
bd8d7d7 
PR-URL: #17170
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisjam davisjam davisjam left review comments

@aqrln aqrln aqrln approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@fhinkel fhinkel fhinkel approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. fast-track PRs that do not need to wait for 48 hours to land. net Issues and PRs related to the net subsystem. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.