lib: add `process` to internal module wrapper #17198

addaleax · 2017-11-21T18:29:12Z

Share process through the module wrapper rather than relying
on nobody messing with global.process.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

lib (but in particular the REPL)

Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. Fixes: nodejs#6802

bnoordhuis

I have a curious sense of double deja vu: both of reviewing something like this before and of writing it myself...

addaleax · 2017-11-21T18:37:08Z

@bnoordhuis I think we might have tried to add it to the userland module wrapper at some point, which broke existing code that contained statements like const process = ...; – not sure I remember correctly though…

jasnell

Code change LGTM.
Should this be defensively marked semver-major?
Definitely needs a CITGM run.

lance

LGTM - and to think I was going down the ENVIRONMENT_STRONG_PERSISTENT_PROPERTIES rabbit hole. This is nice and clean.

mscdex · 2017-11-21T19:25:29Z

This should be semver-major IMHO.

addaleax · 2017-11-21T19:26:50Z

@mscdex I don’t have a strong opinion personally, but would you mind giving a reason for that? What scenario could this break?

mscdex · 2017-11-21T19:27:30Z

@addaleax For people that may rely on global.process being changed?

addaleax · 2017-11-21T19:29:19Z

@mscdex Changed to what? If the new value doesn’t have the properties as the initial process, that would basically always crash the process from Node’s internals sooner or later anyway, right?

mscdex · 2017-11-21T19:30:05Z

Feel free to remove the label, but I generally like to be defensive about such changes...

jasnell · 2017-11-21T19:32:53Z

I think being defensive is the safest route, if citgm comes up without any problematic hits then I've no problem dropping the label when this lands.

jasnell · 2017-11-21T19:33:41Z

to be clear, @addaleax, I cannot think of a single reasonable case where this would break anyone, but there's no harm in being cautious.

addaleax · 2017-11-27T01:28:56Z

CI: https://ci.nodejs.org/job/node-test-commit/14382/

addaleax · 2017-11-28T01:57:54Z

Landed in e8a26e7

Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. PR-URL: #17198 Fixes: #6802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

apapirovski · 2018-02-23T15:56:36Z

@nodejs/tsc Can we unmake this semver-major per chance? It's actually impossible for Node to get through a single run of the event loop if process gets set to a new object, because we rely on process._tickCallback, process.nextTick and many other things in our internal code.

It's blocking landing #17736 on v9.x

targos · 2018-02-23T16:01:49Z

@apapirovski Are you asking for removing the semver-major label or something else?

apapirovski · 2018-02-23T16:02:33Z

@targos Yes, I'm looking to remove the semver-major label. I think it's overly cautious and we haven't seen any breakages in CitGM on master as a result of this.

In addition to what I said above, if someone just modifies the process object with new properties then those changes will still be available. This merely changes the behaviour if global.process is assigned a new value (which breaks Node anyway...).

targos · 2018-02-23T17:22:19Z

+1 from me

addaleax · 2018-02-23T17:44:11Z

Removed the label for now, we can see if anybody has a differing opinion.

Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. PR-URL: nodejs#17198 Fixes: nodejs#6802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. Backport-PR-URL: #19006 PR-URL: #17198 Fixes: #6802 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins · 2018-07-31T18:19:01Z

This does not land cleanly in v8.x LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

edit: the backport to 9.x came with a number of other PRs (see #19006) it landed in 743cf33...f2dd17b

likely we would want to backport all at once?

lib: add process to internal module wrapper

a5511e4

Share `process` through the module wrapper rather than relying on nobody messing with `global.process`. Fixes: nodejs#6802

addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. repl Issues and PRs related to the REPL subsystem. labels Nov 21, 2017

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 21, 2017

addaleax mentioned this pull request Nov 21, 2017

REPL crashes after let process; #6802

Closed

bnoordhuis approved these changes Nov 21, 2017

View reviewed changes

jasnell approved these changes Nov 21, 2017

View reviewed changes

lance approved these changes Nov 21, 2017

View reviewed changes

mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 21, 2017

mscdex removed the repl Issues and PRs related to the REPL subsystem. label Nov 21, 2017

apapirovski approved these changes Nov 21, 2017

View reviewed changes

joyeecheung approved these changes Nov 21, 2017

View reviewed changes

aqrln approved these changes Nov 22, 2017

View reviewed changes

targos approved these changes Nov 22, 2017

View reviewed changes

cjihrig approved these changes Nov 22, 2017

View reviewed changes

TimothyGu approved these changes Nov 22, 2017

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2017

refack approved these changes Nov 27, 2017

View reviewed changes

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017

addaleax closed this Nov 28, 2017

addaleax deleted the process-internal branch November 28, 2017 01:57

apapirovski mentioned this pull request Feb 23, 2018

timers: make setImmediate() immune to tampering #17736

Closed

addaleax removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 23, 2018

apapirovski mentioned this pull request Feb 26, 2018

[v9.x-backport] Backport #17198, #17738, #17841, #17736, #17881, #17879 and #18139 #19006

Closed

4 tasks

addaleax added the backported-to-v9.x label Feb 26, 2018

addaleax mentioned this pull request Feb 27, 2018

v9.7.0 proposal #19040

Closed

MylesBorins added the backport-requested-v8.x label Jul 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: add `process` to internal module wrapper #17198

lib: add `process` to internal module wrapper #17198

addaleax commented Nov 21, 2017

bnoordhuis left a comment

addaleax commented Nov 21, 2017

jasnell left a comment

lance left a comment

mscdex commented Nov 21, 2017

addaleax commented Nov 21, 2017

mscdex commented Nov 21, 2017

addaleax commented Nov 21, 2017

mscdex commented Nov 21, 2017

jasnell commented Nov 21, 2017

jasnell commented Nov 21, 2017

addaleax commented Nov 27, 2017

addaleax commented Nov 28, 2017

apapirovski commented Feb 23, 2018 •

edited

Loading

targos commented Feb 23, 2018

apapirovski commented Feb 23, 2018 •

edited

Loading

targos commented Feb 23, 2018

addaleax commented Feb 23, 2018

MylesBorins commented Jul 31, 2018 •

edited

Loading

lib: add process to internal module wrapper #17198

lib: add process to internal module wrapper #17198

Conversation

addaleax commented Nov 21, 2017

Checklist

Affected core subsystem(s)

bnoordhuis left a comment

Choose a reason for hiding this comment

addaleax commented Nov 21, 2017

jasnell left a comment

Choose a reason for hiding this comment

lance left a comment

Choose a reason for hiding this comment

mscdex commented Nov 21, 2017

addaleax commented Nov 21, 2017

mscdex commented Nov 21, 2017

addaleax commented Nov 21, 2017

mscdex commented Nov 21, 2017

jasnell commented Nov 21, 2017

jasnell commented Nov 21, 2017

addaleax commented Nov 27, 2017

addaleax commented Nov 28, 2017

apapirovski commented Feb 23, 2018 • edited Loading

targos commented Feb 23, 2018

apapirovski commented Feb 23, 2018 • edited Loading

targos commented Feb 23, 2018

addaleax commented Feb 23, 2018

MylesBorins commented Jul 31, 2018 • edited Loading

lib: add `process` to internal module wrapper #17198

lib: add `process` to internal module wrapper #17198

apapirovski commented Feb 23, 2018 •

edited

Loading

apapirovski commented Feb 23, 2018 •

edited

Loading

MylesBorins commented Jul 31, 2018 •

edited

Loading