-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace function with arrow function in test-child-process-send-cb.js #17312
Closed
spring-raining
wants to merge
1
commit into
nodejs:master
from
spring-raining:arrow_func_in_test_child_process_send_cb
Closed
test: Replace function with arrow function in test-child-process-send-cb.js #17312
spring-raining
wants to merge
1
commit into
nodejs:master
from
spring-raining:arrow_func_in_test_child_process_send_cb
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace some classic functions with arrow functions in test-child-process-send-cb.js
ronkorving
approved these changes
Nov 26, 2017
hiroppy
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Nov 26, 2017
vsemozhetbyt
approved these changes
Nov 26, 2017
targos
approved these changes
Nov 26, 2017
joyeecheung
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Nov 26, 2017
watilde
approved these changes
Nov 26, 2017
lpinca
approved these changes
Nov 26, 2017
gireeshpunathil
approved these changes
Nov 26, 2017
maclover7
approved these changes
Nov 26, 2017
mscdex
added
the
child_process
Issues and PRs related to the child_process subsystem.
label
Nov 26, 2017
jasnell
approved these changes
Nov 26, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 26, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 8b68d48. Thank you and congrats on your PR to core! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
fast-track
PRs that do not need to wait for 48 hours to land.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some classic functions with arrow functions in test-child-process-send-cb.js
Thie PR is a part of Code and Learn at NodeFest 2017! (nodejs/code-and-learn#72)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
N/A