Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor using template string #17314

Closed
wants to merge 1 commit into from
Closed

test: refactor using template string #17314

wants to merge 1 commit into from

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Nov 26, 2017

This is part of NodeFest's Code and Learn nodejs/code-and-learn#72

I replaced string concatnation with template string literal where it's appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@kt3k
test: refactor using template string
6e735a4 
Use template string where it's appropriate.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11723/

@joyeecheung joyeecheung added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 26, 2017
@mscdex mscdex added the zlib Issues and PRs related to the zlib subsystem. label Nov 26, 2017
jasnell
jasnell approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure in CI is unrelated

jasnell pushed a commit that referenced this pull request Nov 26, 2017
@kt3k @jasnell
test: refactor using template string
2124d0e 
Use template string where it's appropriate.

PR-URL: #17314
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in 2124d0e. Thank you!

@jasnell jasnell closed this Nov 26, 2017
@kt3k kt3k deleted the feature/use-template-string branch December 1, 2017 13:57
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kt3k @MylesBorins
test: refactor using template string
7fb6f93 
Use template string where it's appropriate.

PR-URL: #17314
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@kt3k @MylesBorins
test: refactor using template string
e35aced 
Use template string where it's appropriate.

PR-URL: #17314
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@maclover7 maclover7 maclover7 approved these changes

@targos targos targos approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.